Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable state probing for OptimizationSolver on CPU and Loihi backend #217

Merged
merged 18 commits into from
May 3, 2023
Merged

Enable state probing for OptimizationSolver on CPU and Loihi backend #217

merged 18 commits into from
May 3, 2023

Conversation

AlessandroPierro
Copy link
Collaborator

@AlessandroPierro AlessandroPierro commented Apr 27, 2023 •
edited
Loading

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Feature

What is the new behavior?

  • It is now possible to track the neuron state through time during the execution of OptimizationSolver and obtain the timeseries at the end of execution
  • The state probing can be requested setting SolverConfig.probe_state to True when calling the solve method of OptimizationSolver
  • The state timeseries is returned in SolverReport.state_timeseries

Does this introduce a breaking change?

  • No

@AlessandroPierro AlessandroPierro self-assigned this Apr 27, 2023
@AlessandroPierro AlessandroPierro added the 1-feature New feature or request label Apr 27, 2023
@AlessandroPierro AlessandroPierro changed the title Enable state probing for OptimizationSolver Enable state probing for OptimizationSolver on Cpu and Loihi backend Apr 27, 2023
@AlessandroPierro AlessandroPierro changed the title Enable state probing for OptimizationSolver on Cpu and Loihi backend Enable state probing for OptimizationSolver on CPU and Loihi backend Apr 27, 2023
@AlessandroPierro AlessandroPierro mentioned this pull request Apr 27, 2023
Merged
9 tasks
@AlessandroPierro AlessandroPierro marked this pull request as ready for review April 27, 2023 14:23
@AlessandroPierro
Copy link
Collaborator Author

Ready for review. Tests are passing locally, and will pass in the CI when lava-nc/lava#675 is merged.

GaboFGuerra
GaboFGuerra approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@GaboFGuerra GaboFGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alessandro!

@AlessandroPierro AlessandroPierro merged commit 4e2f36e into main May 3, 2023
@AlessandroPierro AlessandroPierro deleted the state-tracking branch July 6, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phstratmann phstratmann phstratmann left review comments

@GaboFGuerra GaboFGuerra GaboFGuerra approved these changes

Assignees

@AlessandroPierro AlessandroPierro

Labels
1-feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlessandroPierro @GaboFGuerra @phstratmann